If it is an automatic charger and it will not shut off there is a problem. Usually there is a bad battery in the pack that can cause this. Charge time can vary from a couple hours to 16 hours. How old are the batteries? Did you check the water in them? Use distilled water if you need to fill them and make sure all connections are tight and clean.